[PATCH] 505 Removed unnecessary variable in ConfigurationUtils.configCert().
by Endi Sukma Dewata
The original_caType variable has been removed because it's not
necessary. The variable was used to store the original value of
caType, but after restoring the original value, the caType was
no longer used by the code. So it's actually not necessary to
restore the original value, and therefore it's not necessary to
keep the original value of caType.
Ticket #990
--
Endi S. Dewata
10 years, 10 months
[PATCH] Refactored CertRevokeRequest and CertUnrevokeRequest classes in Dogtag 10
by Abhishek Koneru
Please review the patch which refactors the CertRevokeRequest class and
removes the CertUnrevokeRequest class in Dogtag 10. Description of the
patch:
There seems to be no use of the requestID parameter in both revoke
and unrevoke request. Removed requestID attribute in CertRevokeRequest
remove the class CertUnrevokeRequest.
Also made changes in RevocationProcesor to use the requestID of the
request created in it.
The setRequestID() is being called in the DoRevoke and DoUnRevoke
servlets.
Removed the call and a function auditRequesterId in both the classes.
The auditRequestorId method tries to get a "requestID" stored as a INPUT
field
in the reasonToRequest page. The ReasonToRevoke class which generates
this page does not set the value.
* This patch is required for patch 92. The unrevoke_request method in
CertClient on the python side will not work without this patch.
--Abhishek
10 years, 10 months
[PATCH] 503 Replaced group for RegisterUser.
by Endi Sukma Dewata
The RegisterUser servlets in CA, KRA, and TKS have been updated to
add the user into Trusted Managers group instead of Agents.
A new upgrade script has been added to update existing instances.
The XML formatting in TKS's web.xml has been cleaned up.
Ticket #990
--
Endi S. Dewata
10 years, 10 months
[PATCHES] PKI TRAC Ticket #946 - Installation of IPA hangs up when LANG is set to tr_TR.UTF8 [Fedora 20]
by Matthew Harmsen
Please review the two attached patches which address:
* PKI TRAC Ticket #946 - Installation of IPA hangs up when LANG is set
to tr_TR.UTF8 <https://fedorahosted.org/pki/ticket/946>
The first patch attempts to insure that 'UTF-8' encoding is always used
when importing data from an LDIF file by replacing the Java commands
which utilize the default Locale and thus potentially would override the
use of 'UTF-8' when working with LDIF files.
The following ticket has been issued to address further concerns related
to this issue:
* PKI TRAC Ticket #1005 - Analyze source code for Java commands which
utilize default Locale and honor 'i18n'
<https://fedorahosted.org/pki/ticket/1005>
The second patch specifically addresses the use of the 'tr_TR.UTF-8'
issue reported in this ticket by changing the following problematic LDIF
attribute names:
* index.ldif
o nsIndexType --> nsindexType
o nsSystemIndex --> nsSystemindex
* vlvtasks.ldif
o nsInstance --> nsinstance
o nsIndexVLVAttribute --> nsindexVLVAttribute
The root of the problem that appears to cause this issue is the use of
the 'toLowerCase()' method as utilized in the LDAPJDK. The following
bug has been issued which fully describes this issue:
* Bugzilla Bug #1097868 - Proposal: Consider not honoring 'i18n' on
LDAP attribute names . . .
<https://bugzilla.redhat.com/show_bug.cgi?id=1097868>
These patches were tested on a 64-bit Fedora 20 machine by doing the
following:
* Install the patched RPMS onto the Fedora 20 test machine
* Set contents of '/etc/locale.conf':
o LANG="tr_TR.UTF-8"
* Reboot machine
* LANG="tr_TR.UTF-8" ssh root(a)fedora20.example.com
* cat /etc/resolv.conf
* ipa-server-install --setup-dns
o Choose defaults and change the BIND settings using the values
from '/etc/resolv.conf'
* klist
* kinit admin
* klist
* ipa user-find
* ipa help cert
* ipa cert-show
10 years, 10 months
profile inputs and constraints; open tickets?
by Fraser Tweedale
Hi y'all,
For my next blog post I'm going to modify and/or implement some
profile inputs or constraints. It would be good to do something
that's actually needed.
I've have a quick look on the Trac for tickets in this area; a few
pertain to issues with validity and DN selection - #858 looks
particularly juicy - but I didn't see any that required new
constraints/inputs/defaults.
If anyone has a preference for what I should tackle in this exercise
or knows of a relevant ticket I may have overlooked, let me know.
Cheers,
Fraser
10 years, 10 months
[PATCH] 502 Added minimum search keyword length requirement.
by Endi Sukma Dewata
Some REST services that accept search keywords have been modified to
require a minimum length of 3 characters.
The DEFAULT_SIZE constant has been moved into the base PKIService
class to reduce multiple declarations.
Ticket #920
--
Endi S. Dewata
10 years, 10 months