On 4/2/2013 11:54 AM, Abhishek Koneru wrote:
Please review the patch which adds a locking mechanism to prevent
pkispawn and pkidestroy to execute concurrently.
Some comments:
1. This mechanism locks the entire system, so only one
pkispawn/pkidestroy can run at any time. Is this the intended behavior?
Or should we lock a particular instance only?
2. If another script is already running, the current script will block
until the other script is done. Is this the intended behavior? Or should
it fail immediately? Or should it wait but show a message saying another
script is running?
3. Right now the lock file is called /tmp/pkioperationlock.lck. It might
be better to move it into /var/run/pki/pki-deployment.lock or something
like that.
--
Endi S. Dewata