Re: [Pki-devel] skeleton code for drm restful interface

On 12/13/2011 04:55 PM, Ade Lee wrote: I'd forgotten how annoying I find the Bean API. You catch too many exceptions. Let them propagate as far as you can. You should not be cathing them and then rethrowing them. Either catch them and be done with them, or let them bubble up to the top level. I understand the reason for splitting the DAO off from the servlet, but I feel that here the division is too arbitrary. The Resource doesn't do any work, and the fact that these are all methods of the same objects although they do the same thing seems arbitrary. I realize you are following the examples given in the documentation. I think that the Repository already playts the role of the DAO, and putting an additionaly layer in here provides no additional insulation against leaky abstractions.... I also really don't like the split between KeyData and KeyDataInfo. It seems unnecessary. Let the complexity emerge. Write the code in a more inline fashion, and only refactor out once you have a sense of what the real structure is going to be. I'll try to send you back my version of the patch tomorrow: I'm about to lose Laptop battery right now.