Re: [Pki-devel] [PATCH] 91 Refactored CertRevokeRequest and CertUnrevokeRequest classes in Dogtag 10

Sorry for the spam! Please ignore the previous email. --Abhishek On Mon, 2014-05-05 at 06:44 -0400, Abhishek Koneru wrote: > Please review the patch which refactors the CertRevokeRequest class and > removes the CertUnrevokeRequest class in Dogtag 10. Description of the > patch: > > There seems to be no use of the requestID parameter in both revoke > and unrevoke request. Removed requestID attribute in CertRevokeRequest > remove the class CertUnrevokeRequest. > > Also made changes in RevocationProcesor to use the requestID of the > request created in it. > > The setRequestID() is being called in the DoRevoke and DoUnRevoke > servlets. > Removed the call and a function auditRequesterId in both the classes. > > The auditRequestorId method tries to get a "requestID" stored as a INPUT > field > in the reasonToRequest page. The ReasonToRevoke class which generates > this page does not set the value. > > * This patch is required for patch 92. The unrevoke_request method in > CertClient on the python side will not work without this patch. > > --Abhishek > _______________________________________________ > Pki-devel mailing list > Pki-devel(a)redhat.com > https://www.redhat.com/mailman/listinfo/pki-devel _______________________________________________ Pki-devel mailing list Pki-devel(a)redhat.com https://www.redhat.com/mailman/listinfo/pki-devel