Re: [Pki-devel] [PATCH] 59 Refactored audit service.

New patch attached. On 5/23/2012 11:07 PM, Ade Lee wrote: > As mentioned on #irc, the audit() functions in Auditor are too specific > to auditing in the User / Group servlets. It will be difficult to > provide any set of parameters that will cover all cases, so it may be > easiest for now to do what the AdminServlet audit(String msg) function > does -- which is take in a single String argument. Fixed. > The location of the class is also not the best. If nothing else, I > would put it under com.netscape.certsrv.logging as this is where all the > other classes handling auditing functions reside. I put the IAuditor in certsrv.logging and Auditor in cmscore.logging. > The javadoc comments on each of the methods also need to be changed -- > they talk about extended admin servlets. Fixed. > Also, it might be nice to go ahead and change admin servlet right now to > use the new class. This will involve a little more testing -- using > some of the existing servlets and confirming that the audit log messages > are being written - but it will prevent code duplication. I'll post a separate patch. > We will need to use this Auditor class in the other servlets we are > replacing. > > Ade