Re: [Pki-devel] Dealing with the reformat for Simplename
Endi,
I was able to format correctly using my version of eclipse. I also
spent some time cleaning up the most egregious formatting errors - and
think I got most of them.
I applied the same to adam's changes too - with only one easy merge
conflict to be resolved.
Ping me on #irc and I'll post for your review in the morning.
Ade
On Mon, 2012-01-09 at 21:21 -0600, Endi Sukma Dewata wrote:
Ade,
I found that curly braces 'same line' formatting is tied to the 'never
join' setting for line wrapping. If I select 'never join' it will not
join the curly braces into 'same line'. If I unselect 'never join' it
will join the curly braces, but it will join other stuff too, which is
not what we want.
I'm not sure whether this behavior is specific to my Eclipse version
(3.7.1 on F16). If your Eclipse works better please go ahead with
formatting the master branch and Adam's rebased patches in ticket-2
branch below:
http://fedorapeople.org/gitweb?p=edewata/public_git/pki.git;a=summary
Another option is to use the formatting I did in branch ticket-45-2 for
now and address the curly braces problem later.
Thanks.
On 1/9/2012 7:44 AM, Adam Young wrote:
> I think you can work around a reformat this way:
>
> 1. Do a reformat of the code prior to the simplename patch and tag it
> 2. Do a reformat of the code with the simplename patch applied and tag it
> 3. Generate a patch that is the diff of steps 1 and 2
>
> No guarantees, but it should be pretty much the same to apply the new
> patch on top of the reformat as on top of step 1 above.