Re: [Pki-devel] [PATCH] 198-203 patches to address multiple issues in KeyResource server and client code.
Pushed to master.
Removing resource specific exceptions will be relegated to another
patch.
On Tue, 2014-02-25 at 14:11 -0600, Endi Sukma Dewata wrote:
On 2/24/2014 4:33 PM, John Magne wrote:
>
> ACK #200, comment below:
>
>> ACK for patch #200. Just one comment, get_key_info() throws
>> KeyNotFoundException and get_active_key_info() throws
>> ResourceNotFoundException. I think they should be consistent. Also
>> consider removing the resource-specific *NotFoundExceptions.
>
> But do the resource specific exceptions reveal more info as to what has not been
found.
> Will the generic one be able to convey that info? Just a question.
So far the resource-specific exceptions only contain the resource ID and
the client already knows that since it's the one initiating the
operation. A generic ResourceNotFoundException will still contain the
resource ID as part of the error message.