Re: [Pki-devel] [PATCH] 862 TPS rewrite: provide connector service for JAVA-based TPS subsystem
Hi jack,
Thanks for the review!
Please see response below:
On 03/06/2014 05:20 PM, John Magne wrote:
ACK:
I looked over the original and all the subsequent patches.
Functionality looks good. Just a couple of quesitons.
1. Should we have some nice defines in the java code to use that represent the various
known "ops".
Actually, these "ops" are admin-defined in the
CS.cfg as explained in
the comments of ConnectionManager.java (about line 63 and on) .
I'd like to think of the callers being some kind of plugins that can be
written so I think it might be better not to hard-code them.
2. How about some simple sample code somewhere in there that demonstrates the use of this
feature.
Maybe just make a call to the TKS to get random data, and show the code to handle the
response?
Very valid request. In fact, I have a patch coming soon (If I can be
allowed to check in this patch ;-) which will provide all the TKS remote
requests sending and response parsing. It is for ticket #888, which I
plan to submit in three batches, one for each remote subsystem, starting
with TKS. When it comes, not only will you be able to see examples, you
can just call these remote request handlers and get response all sorted
out and parsed for you.
----- Original Message -----
From: "Endi Sukma Dewata" <edewata(a)redhat.com>
To: "Christina Fu" <cfu(a)redhat.com>, pki-devel(a)redhat.com
Sent: Thursday, March 6, 2014 12:39:48 PM
Subject: Re: [Pki-devel] [PATCH] 862 TPS rewrite: provide connector service for
JAVA-based TPS subsystem
On 3/6/2014 11:28 AM, Christina Fu wrote:
> I decided to change the default for connector enable's to false instead
> of true so that the server can start even if no connectors are enabled.
>
> Attached please find the small patch.
>
> thanks,
> Christina
ACK.