23 Feb
2017
23 Feb
'17
11:26 p.m.
On 2/23/2017 4:54 PM, Christina Fu wrote:
I only have time to play with it. So this review is not based on code reading. I was able to trigger a session timeout and the banner appears again as expected. So from that point of view, as long as the patches don't break existing banner-ignorant clients, ack.
And again, please make sure it works with IE.
Christina
Thanks! Pushed to master. -- Endi S. Dewata