[PATCH] 957 Added access banner for PKI UI.
The PKI UI main page has been modified to retrieve access banner and display it once at the beginning of the SSL connection. https://fedorahosted.org/pki/ticket/2582 -- Endi S. Dewata
First, as discussed over irc, the banner should be re-displayed when an ssl session ends. Sounds like sessonStorage might not do what is expected. Please also make sure the resulting code works with IE. thanks! Christina On 02/22/2017 11:57 AM, Endi Sukma Dewata wrote:
The PKI UI main page has been modified to retrieve access banner and display it once at the beginning of the SSL connection.
https://fedorahosted.org/pki/ticket/2582
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On 02/22/2017 04:51 PM, Christina Fu wrote:
First, as discussed over irc, the banner should be re-displayed when an ssl session ends. Sounds like sessonStorage might not do what is expected.
correction. I meant to say "the banner should be re-displayed when an ssl session ends and a new session begins"
Please also make sure the resulting code works with IE.
thanks!
Christina
On 02/22/2017 11:57 AM, Endi Sukma Dewata wrote:
The PKI UI main page has been modified to retrieve access banner and display it once at the beginning of the SSL connection.
https://fedorahosted.org/pki/ticket/2582
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On 2/22/2017 1:57 PM, Endi Sukma Dewata wrote:
The PKI UI main page has been modified to retrieve access banner and display it once at the beginning of the SSL connection.
New patch #957-1 attached. It's now using the two REST services added in patch #956-1. -- Endi S. Dewata
I only have time to play with it. So this review is not based on code reading. I was able to trigger a session timeout and the banner appears again as expected. So from that point of view, as long as the patches don't break existing banner-ignorant clients, ack. And again, please make sure it works with IE. Christina On 02/23/2017 01:47 PM, Endi Sukma Dewata wrote:
On 2/22/2017 1:57 PM, Endi Sukma Dewata wrote:
The PKI UI main page has been modified to retrieve access banner and display it once at the beginning of the SSL connection.
New patch #957-1 attached. It's now using the two REST services added in patch #956-1.
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On 2/23/2017 4:54 PM, Christina Fu wrote:
I only have time to play with it. So this review is not based on code reading. I was able to trigger a session timeout and the banner appears again as expected. So from that point of view, as long as the patches don't break existing banner-ignorant clients, ack.
And again, please make sure it works with IE.
Christina
Thanks! Pushed to master. -- Endi S. Dewata
participants (2)
-
Christina Fu -
Endi Sukma Dewata