[PATCH] 51 Remove sensitive parameters from the archived configuration file. Ticket #566
Please review the patch which removes storing the sensitive parameters in the archived deployment configuration file. (Ticket #566) --Abhishek
Comments: 1. Can you explain the addition of the line in pkiparser.py? 2. I would prefer that the sensitive parameters still be logged - but with values XXXXXX, rather than being removed. Ade On Wed, 2013-04-10 at 16:31 -0400, Abhishek Koneru wrote:
Please review the patch which removes storing the sensitive parameters in the archived deployment configuration file. (Ticket #566)
--Abhishek _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
Please review the patch with fixes to the comments given for patch 51. --Abhishek On Wed, 2013-04-17 at 10:12 -0400, Ade Lee wrote:
Comments:
1. Can you explain the addition of the line in pkiparser.py? 2. I would prefer that the sensitive parameters still be logged - but with values XXXXXX, rather than being removed.
Sensitive parameters have values as XXXXXXXX in the archived file.
Ade
On Wed, 2013-04-10 at 16:31 -0400, Abhishek Koneru wrote:
Please review the patch which removes storing the sensitive parameters in the archived deployment configuration file. (Ticket #566)
--Abhishek _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
ACK'ed by Ade. Pushed to master. On Wed, 2013-04-17 at 11:28 -0400, Abhishek Koneru wrote:
Please review the patch with fixes to the comments given for patch 51.
--Abhishek
On Wed, 2013-04-17 at 10:12 -0400, Ade Lee wrote:
Comments:
1. Can you explain the addition of the line in pkiparser.py? 2. I would prefer that the sensitive parameters still be logged - but with values XXXXXX, rather than being removed.
Sensitive parameters have values as XXXXXXXX in the archived file.
Ade
On Wed, 2013-04-10 at 16:31 -0400, Abhishek Koneru wrote:
Please review the patch which removes storing the sensitive parameters in the archived deployment configuration file. (Ticket #566)
--Abhishek _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (2)
-
Abhishek Koneru -
Ade Lee