[PATCH] 48 Show some more information after installation
Please review the patch that print the command to check status and the URL of the installed subsystem. The actual ticket also says to remove the extra console output if there is no -v option specified. The console log level is already set to WARNING, rather than INFO. --Abhishek
Some more changes added to the patch. Please ignore the previous post. Please review the attached patch. --Abhishek On Thu, 2013-04-04 at 12:35 -0400, Abhishek Koneru wrote:
Please review the patch that print the command to check status and the URL of the installed subsystem.
The actual ticket also says to remove the extra console output if there is no -v option specified. The console log level is already set to WARNING, rather than INFO.
--Abhishek _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On 4/5/2013 9:59 AM, Abhishek Koneru wrote:
Some more changes added to the patch. Please ignore the previous post. Please review the attached patch.
Some comments: 1. There's a typo: PKI_CHECK_STATUS_MESSAGE = "COmmand... 2. Please also show the following information: - Admin username - Location of client database - Client certificate nickname This way the admin knows the parameters needed to use the CLI. 3. Could we move these messages before 'Installation complete'? If the messages are long it will be more difficult to see the result of the installation. 4. Some trailing whitespaces. -- Endi S. Dewata
Please review the patch with fixes for the review comments for patch 48 On Mon, 2013-04-08 at 13:25 -0500, Endi Sukma Dewata wrote:
On 4/5/2013 9:59 AM, Abhishek Koneru wrote:
Some more changes added to the patch. Please ignore the previous post. Please review the attached patch.
Some comments:
1. There's a typo:
PKI_CHECK_STATUS_MESSAGE = "COmmand...
2. Please also show the following information: - Admin username - Location of client database - Client certificate nickname
Added these details.
This way the admin knows the parameters needed to use the CLI.
3. Could we move these messages before 'Installation complete'? If the messages are long it will be more difficult to see the result of the installation.
Information is printed above the 'Installation complete' message.
4. Some trailing whitespaces.
Fixed.
--Abhishek
ACK'ed by Endi. Pushed to master. On Tue, 2013-04-09 at 16:03 -0400, Abhishek Koneru wrote:
Please review the patch with fixes for the review comments for patch 48
On Mon, 2013-04-08 at 13:25 -0500, Endi Sukma Dewata wrote:
On 4/5/2013 9:59 AM, Abhishek Koneru wrote:
Some more changes added to the patch. Please ignore the previous post. Please review the attached patch.
Some comments:
1. There's a typo:
PKI_CHECK_STATUS_MESSAGE = "COmmand...
2. Please also show the following information: - Admin username - Location of client database - Client certificate nickname
Added these details.
This way the admin knows the parameters needed to use the CLI.
3. Could we move these messages before 'Installation complete'? If the messages are long it will be more difficult to see the result of the installation.
Information is printed above the 'Installation complete' message.
4. Some trailing whitespaces.
Fixed.
--Abhishek
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (2)
-
Abhishek Koneru -
Endi Sukma Dewata