[PATCH] pki-cfu-0088-Ticket-1307-issue-FilterMappingResolver-always-retur.patch
This patch fixes a regression introduced in https://fedorahosted.org/pki/ticket/1307 [RFE] Support multiple keySets for different cards for ExternalReg where it missed assigning the calculated result to be returned. It has been tested to work. There is also one simple typo fix in there that doesn't have anything to do with the feature in question. thanks, Christina
OK, after looking at this for a while,and I finally get the gist of it. We want to throw an exception in the case where none of the mapping filters match. The regression was causing us to return the "target" of the last filter in the list, which is wrong. The previous behavior called for throwing an exception when nothing matches, and this brings that back. If tested in a few scenarios to work, ACK . ----- Original Message ----- From: "Christina Fu" <cfu@redhat.com> To: "pki-devel" <pki-devel@redhat.com> Sent: Tuesday, July 28, 2015 4:33:01 PM Subject: [Pki-devel] [PATCH] pki-cfu-0088-Ticket-1307-issue-FilterMappingResolver-always-retur.patch This patch fixes a regression introduced in https://fedorahosted.org/pki/ticket/1307 [RFE] Support multiple keySets for different cards for ExternalReg where it missed assigning the calculated result to be returned. It has been tested to work. There is also one simple typo fix in there that doesn't have anything to do with the feature in question. thanks, Christina _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
pushed to master: commit b68fc753775cf49dcd3bafe046c71dda08ca6b9a thanks, Christina On 07/28/2015 05:08 PM, John Magne wrote:
OK, after looking at this for a while,and I finally get the gist of it.
We want to throw an exception in the case where none of the mapping filters match. The regression was causing us to return the "target" of the last filter in the list, which is wrong. The previous behavior called for throwing an exception when nothing matches, and this brings that back.
If tested in a few scenarios to work, ACK .
----- Original Message ----- From: "Christina Fu" <cfu@redhat.com> To: "pki-devel" <pki-devel@redhat.com> Sent: Tuesday, July 28, 2015 4:33:01 PM Subject: [Pki-devel] [PATCH] pki-cfu-0088-Ticket-1307-issue-FilterMappingResolver-always-retur.patch
This patch fixes a regression introduced in https://fedorahosted.org/pki/ticket/1307 [RFE] Support multiple keySets for different cards for ExternalReg where it missed assigning the calculated result to be returned.
It has been tested to work.
There is also one simple typo fix in there that doesn't have anything to do with the feature in question.
thanks, Christina
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (2)
-
Christina Fu -
John Magne