[pki-devel][PATCH] 0045-op.format.externalRegAddToToken.revokeCert-parameter.patch
op.format.externalRegAddToToken.revokeCert parameter missing in TPS CS.cfg. It is true that his setting is not present. The generic code that revokes certs for a format checks this value. No harm in putting this value in the CS.cfg and setting it to false by default for the externalRegAddToToken profile. No harm in giving the user the way to use this feature , even if we decide it is not a good idea to revoke certs associated with the external reg feature.
the externalRegAddToToken profile was meant for adding certs/keys to the token, so no deletion is supposed to happen, hence no revoke check necessary. It does no harm to add that param though. ACK. Christina On 07/28/2015 05:57 PM, John Magne wrote:
op.format.externalRegAddToToken.revokeCert parameter missing in TPS CS.cfg.
It is true that his setting is not present. The generic code that revokes certs for a format checks this value. No harm in putting this value in the CS.cfg and setting it to false by default for the externalRegAddToToken profile. No harm in giving the user the way to use this feature , even if we decide it is not a good idea to revoke certs associated with the external reg feature.
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
ACKed, verbally and email by cfu. Pushed to master. Closing ticket #1511 ----- Original Message ----- From: "John Magne" <jmagne@redhat.com> To: "pki-devel" <pki-devel@redhat.com> Sent: Tuesday, July 28, 2015 5:57:20 PM Subject: [Pki-devel] [pki-devel][PATCH] 0045-op.format.externalRegAddToToken.revokeCert-parameter.patch op.format.externalRegAddToToken.revokeCert parameter missing in TPS CS.cfg. It is true that his setting is not present. The generic code that revokes certs for a format checks this value. No harm in putting this value in the CS.cfg and setting it to false by default for the externalRegAddToToken profile. No harm in giving the user the way to use this feature , even if we decide it is not a good idea to revoke certs associated with the external reg feature. _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (2)
-
Christina Fu -
John Magne