[PATCH] 262 man pages for pki-server
On 7/15/2015 3:16 PM, Ade Lee wrote:
Please review.
Ade
Some comments: 1. In all files the [CLI options] should be placed after pki-server and the [command options] should be placed after the command name: pki-server [CLI options] instance-show [command options] <instance ID> 2. In pki-server-instance the <instance_ID> should be replaced with <instance ID> (no underscore). 3. In pki-server-instance the "server administrator" probably should be changed to "system administrator". 4. In pki-server-subsystem the "pki-server subsystem show" should be changed to "pki-server subsystem-show" (with dash). 5. I think the authors list refers to the man page authors, not the CLI authors. 6. The spec file needs to be updated to include the man pages, otherwise they won't be installed. Once these are addressed, it's ACKed. -- Endi S. Dewata
Changes done. Thanks. Pushed to master. Ade On Thu, 2015-07-16 at 08:35 -0500, Endi Sukma Dewata wrote:
On 7/15/2015 3:16 PM, Ade Lee wrote:
Please review.
Ade
Some comments:
1. In all files the [CLI options] should be placed after pki-server and the [command options] should be placed after the command name:
pki-server [CLI options] instance-show [command options] <instance ID>
2. In pki-server-instance the <instance_ID> should be replaced with <instance ID> (no underscore).
3. In pki-server-instance the "server administrator" probably should be changed to "system administrator".
4. In pki-server-subsystem the "pki-server subsystem show" should be changed to "pki-server subsystem-show" (with dash).
5. I think the authors list refers to the man page authors, not the CLI authors.
6. The spec file needs to be updated to include the man pages, otherwise they won't be installed.
Once these are addressed, it's ACKed.
participants (2)
-
Ade Lee -
Endi Sukma Dewata