Looks pretty good. 1. list_entrollment_templates has a print r statement in it. Is that supposed to be there? 2. get_enrollment_template should check for None for the profileID. 3. CertRequestInfoCollection has an element - cert_info_list, should be cert_request_info_list 4. ProfileConstraint -- why is id renamed to name? Why not just use "id" 5. We need some documentation, either in the class docstring or elsewhere in the file that explains why some attributes have been defined as properties with a setter and some have not. You should explain that these properties need to be transformed to be sent back to the server. Once these are fixed, ACK. On Tue, 2014-05-20 at 11:02 -0400, Abhishek Koneru wrote:

Please review the attached patch which adds methods to deal with the CertRequest resource in CertClient on the python side.

These methods provide functionality like -

-Fetching the enrollment templates. -Creating an enrollment request from a dictionary of input key-value pairs. -Submitting an enrollment request. -Reviewing the request. -Performing an action on a request(approve/reject/cancel/etc.)

Also defined all the classes needed for data representation.

--Abhishek _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel