[PATCH] 104 Make the return type of the secrets returned by the KeyClient consistent on both Java and Python sides
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
Currently, the secrets retrieved using the retrieveKey method of the KeyClient are of the
type byte[]. (Attribute of the Key object).
But the public key, which is returned in a KeyInfo object, is being accessible as a string
(base64 encoded binary data).
This patch changes getter/setter of the publicKey attribute of the KeyInfo object to do
the conversion from base64 encoded string to byte[] and vice versa.
With this patch all the keys retrieved are of the type byte[].
Please review the attached patch.
-- Abhishek
Attachments:
- pki-akoneru-0104-Makes-output-of-secrets-consistent-for-all-clients.patch (text/x-patch — 8.2 KB)
ACK
On Thu, 2014-08-28 at 19:24 -0400, Abhishek Koneru wrote:
Currently, the secrets retrieved using the retrieveKey method of the
KeyClient are of the type byte[]. (Attribute of the Key object).
But the public key, which is returned in a KeyInfo object, is being accessible as a
string (base64 encoded binary data).
This patch changes getter/setter of the publicKey attribute of the KeyInfo object to do
the conversion from base64 encoded string to byte[] and vice versa.
With this patch all the keys retrieved are of the type byte[].
Please review the attached patch.
-- Abhishek
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
On 8/28/2014 6:24 PM, Abhishek Koneru wrote:
Currently, the secrets retrieved using the retrieveKey method of the
KeyClient are of the type byte[]. (Attribute of the Key object).
But the public key, which is returned in a KeyInfo object, is being accessible as a
string (base64 encoded binary data).
This patch changes getter/setter of the publicKey attribute of the KeyInfo object to do
the conversion from base64 encoded string to byte[] and vice versa.
With this patch all the keys retrieved are of the type byte[].
Please review the attached patch.
-- Abhishek
Just one thing, in KeyInfo.java the publicKey should be stored
internally as byte array because that's the most efficient way to store
and use binary data. Base-64 encoding should only be used for
input/ouput that cannot handle binary data well (e.g. text file, CLI
output, logging, JSON/XML).
Once this is fixed, it's ACKed.
--
Endi S. Dewata
3521
days inactive
3522
days old
2 comments
3 participants
tags (0)
participants (3)
-
Abhishek Koneru -
Ade Lee -
Endi Sukma Dewata