[PATCH] 103 Fixes for tickets 1087, 1089, 1090 and 1091
Please review the patch with fixes for tickets 1087, 1089, 1090, 1091. All of them are minor issues in various pki-key CLI commands. -- Abhishek
There is a semi-colon on its own line (and completely unneeded) in KeyTemplateShowCLI.java. Other than that, looks pretty straightforward. ACK On Wed, 2014-08-27 at 10:50 -0400, Abhishek Koneru wrote:
Please review the patch with fixes for tickets 1087, 1089, 1090, 1091.
All of them are minor issues in various pki-key CLI commands.
-- Abhishek _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On 8/27/2014 9:50 AM, Abhishek Koneru wrote:
Please review the patch with fixes for tickets 1087, 1089, 1090, 1091.
All of them are minor issues in various pki-key CLI commands.
-- Abhishek
ACK, just some minor issues: 1. In pki-key.1 the --output parameter description should be short and in lower case (because it's not a full sentence): pki key-template-show archiveKey --output <output file> pki key-template-show retrieveKey --output <output file> pki key-template-show generateKey --output <output file> 2. In KeyCLI.java the "ID" should always be capitalized: if (info.getClientKeyID() != null) System.out.println(" Client Key ID: "+info.getClientKeyID()); 3. In KeyFindCLI.java a shorter "ID" would be better for argument name and lower case for everything else: option.setArgName("client key ID"); 4. In KeyTemplateShowCLI.java the description could be improved and the argument name should match the man page (see #1). Option option = new Option(null, "output", true, "Location to store the template."); option.setArgName("output file"); -- Endi S. Dewata
Fixed all the comments and pushed the patch to master. Closed the relevant tickets. -- Abhishek On Fri, 2014-08-29 at 09:23 -0500, Endi Sukma Dewata wrote:
On 8/27/2014 9:50 AM, Abhishek Koneru wrote:
Please review the patch with fixes for tickets 1087, 1089, 1090, 1091.
All of them are minor issues in various pki-key CLI commands.
-- Abhishek
ACK, just some minor issues:
1. In pki-key.1 the --output parameter description should be short and in lower case (because it's not a full sentence):
pki key-template-show archiveKey --output <output file> pki key-template-show retrieveKey --output <output file> pki key-template-show generateKey --output <output file>
2. In KeyCLI.java the "ID" should always be capitalized:
if (info.getClientKeyID() != null) System.out.println(" Client Key ID: "+info.getClientKeyID());
3. In KeyFindCLI.java a shorter "ID" would be better for argument name and lower case for everything else:
option.setArgName("client key ID");
4. In KeyTemplateShowCLI.java the description could be improved and the argument name should match the man page (see #1).
Option option = new Option(null, "output", true, "Location to store the template."); option.setArgName("output file");
participants (3)
-
Abhishek Koneru -
Ade Lee -
Endi Sukma Dewata