On 9/2/2014 9:16 PM, Fraser Tweedale wrote:
13. The ProfileResource.retrieveProfileRaw() returns a byte[]. Although it works just fine for this purpose, I think returning a Properties would make it more developer-friendly. That way the output is readily usable, and it takes care of any CR/LF issue across different platforms. Maybe call it getProfileProperties()?
I'll look into this implications and benefits of doing this... once I've done all the other things :)
+1 Lets make it more developer friendly.
SimpleProperties and PropConfigStore currently live in com.netscape.cmscore.base. Is there any objection to moving them to com.netscape.certsrv.base so that they are available to the CLI code?
This item is the last of the review items (including Endi's subsequent review) blocking the next cut of the patchset.
Do those classes have dependencies on other server-side classes? I was thinking to simply use java.util.Properties. Or maybe just a String then the ProfileClient parses it into a Properties. -- Endi S. Dewata