17 Dec
2011
17 Dec
'11
1:24 a.m.
On 12/13/2011 4:25 PM, Adam Young wrote:
On 12/13/2011 02:03 PM, Andrew Wnuk wrote:
Hopefully this patch was extremely well tested since it touches ASN.1 encoding. Do you have a specific set of tests that we should be running?
I just posted patch #5 which contains some unit tests for the converters. I've also updated and split patch #4 into #4-2a (renaming the files) and #4-2b (replacing the implementation). Patch #5 should be applied before #4-2a/b to make sure there's no regression. Mozilla JSS library also has some ASN.1 code, should we use them to implement the converters? http://mxr.mozilla.org/mozilla/source/security/jss/org/mozilla/jss/asn1/ -- Endi S. Dewata