1. There are cgi scripts which are explicitly set to have execute permissions by the build script. Is this not needed? Can you confirm this? 2. As mentioned in a previous review, cfg.pl is needed. 3. Are there really no changes required in pkicreate and pkiremove? Surely there must be code that copies stuff from /usr/share/pki/tps-ui and /usr/share/pki/ra-ui. There may even be a programmatic check for the ui package. And don't we need code to copy the relevant bits from common-ui? 4. How was this tested? Do you pkicreate and configure RA and TPS instances? When the instances are created, are all the relevant files where you expect them to be ?-- ie. compare the layout of old/new instances. Did you configure the instances and check the UI to make sure it looks the same? Did you look at the security officer workstation stuff ? Or configure a token? Ade On Tue, 2012-11-27 at 16:15 -0600, Endi Sukma Dewata wrote:
The RA and TPS theme packages are no longer necessary due to the reorganization of the theme files. The build and deployment scripts have been updated accordingly.
Ticket #407
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel