On 3/4/2014 10:08 AM, Endi Sukma Dewata wrote:
On 3/4/2014 9:19 AM, Ade Lee wrote:
For the most part, this looks good.
I have only one question - what happens when a client passes in either no Accepts or no Content-Type header - or is this even possible?
Thanks, Ade
The Apache HTTP client for Java and python-requests libraries would generate those headers by default. Other clients such as curl and Firefox always generate those headers. I think this covers all clients that we want to support including IPA.
I suppose someone could create a raw socket and send HTTP requests without those headers, but I don't think we want to support that. If the client doesn't tell the server what it's sending or how it wants the response back, the server is not required or may not be able to respond properly.
ACKed by Jack & Ade. Pushed to master. -- Endi S. Dewata