----- Original Message ----- From: "Adam Young" <ayoung@redhat.com> To: pki-devel@redhat.com Sent: Monday, December 5, 2011 2:57:28 PM Subject: Re: [Pki-devel] [PATCH] 0019-PKISilent-type-safety-changes On 12/05/2011 05:46 PM, Adam Young wrote: On 11/16/2011 10:00 PM, Adam Young wrote: Tested by running ipa-server-install, which calls pkisilent. _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel Rebased _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel Last one accidentally picked up some patch artifacts it should not have. _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel ACK! Patch looks good and compiles for me in Eclipse: When I tried to apply it though I got this after removing the "<" from the file. Applying: PKISilent type safety changes /home/jmagne/pki-git-test/pki/.git/rebase-apply/patch:817: trailing whitespace. defaultHelpOption = firstHelpOption = matchList.get(0); /home/jmagne/pki-git-test/pki/.git/rebase-apply/patch:861: trailing whitespace. { ((Vector<Object>)rec.resHolder).add (result); warning: 2 lines add whitespace errors. If this is a non-issue, go ahead.