ACK - Looks like our integration framework isn't there yet, and no reason to hold this up till it is. On Fri, 2015-10-02 at 14:35 -0400, Ade Lee wrote:
Conditional ACK.
The patch itself is fine. However, its time we got into the habit of adding functional tests for fixes we make.
We don't really have a good place for these, but there is a placeholder location in the main_ function in the authority.py python file. We need to add some test code there. We'll need to revamp these tests soon and use the pytest framework, but we won't know to test this condition unless the test case is there.
So, please add soem test code and confirm it works.
Ade
ps. You'll probably want to check in your delete patch and the correspo nding python code first.
On Thu, 2015-10-01 at 13:53 +1000, Fraser Tweedale wrote:
The attached patch (which replaces an earlier patch 0050) fixes https://fedorahosted.org/pki/ticket/1628.
Cheers, Fraser _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel