On Mon, Jan 26, 2015 at 11:21:27PM -0600, Endi Sukma Dewata wrote:
Thanks for the review. Comments below.
On 1/26/2015 9:44 PM, Fraser Tweedale wrote:
Tested in conjection with 545. ACK modulo comments:
1. Subsystem enable/disable requires instance restart to take effect. If this is intended/unavoidable, that's fine, but could be made clearer.
Actually with patch #531-3 and #545 the webapp auto deploy will be activated, so enabling/disabling subsystem should take effect in a few seconds automatically, no restart is needed. When auto deploy is enabled, Tomcat will monitor the <instance>/conf/Catalina/localhost folder to see if a webapp deployment descriptor is added or deleted, then it will deploy/undeploy the webapp accordingly.
Ah, I did not run the upgrade script. ACK if tested.
Alternatively we probably can use JMX, but that will require some investigation: https://fedorahosted.org/pki/ticket/1246
2. What are the implications for Debian/Ubuntu with hardedcoded calls to systemctl? Could you dispatch to systemctl/service/upstart as appropriate?
The code is at least initially written for Fedora. I'm not sure if it will work on Debian/Ubuntu, perhaps someone familiar with it could help. If there's a reliable way to detect the distribution we probably can generate the proper command for each distribution.
I believe systemd is headed to Debian 8 and a future Ubuntu release but it's not there yet. The suggested change should be simple so I don't think it should block this patch in its current form. Hopefully it does not exasperate Timo too much. Cheers, Fraser
-- Endi S. Dewata