Re: [Pki-devel] [PATCH] 529 Updated KRA Python client library.
On Wed, 2014-10-08 at 13:45 -0500, Endi Sukma Dewata wrote:
The Python client library for KRA has been modified to simplify
the usage. The NSSCryptoProvider's setup_database() and __init__()
now take a password file parameter. The import_cert() now can
take either cert binary/encoded data or CertData object. It also
provides a default value for the trust attribute. The KRAClient
now stores the crypto provider object.
The KRA test has been updated to provide options to override
the default test configuration (e.g. hostname, port). It also has
been modified to use a temporary NSS database. The setup document
has been updated to describe the process to run the test as root
and as a regular user.
Looks good. ACK.
Just one issue below:
1. In crypto.py, in lines 117-120, is it possible for an exception to be
thrown, leaving the password file lying around? That is one of the
advantages of the with ... construction. Maybe move lines 116 -120 into
the try: block.
Ade
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel