Went through the 15 patches. Looks pretty straightforward and acks for the first 12 and the last patch, which the following comment: 1. Please add comments to describe some of the changes being made so that we have a record for later on. This is particularly true for things like adding absolute_import (which doesn't have a reference in the code and someone might be tempted to remove in future). On patch 13 - Manually fix import problems and access to Exception.message, I have the following question: 2. In base/server/python/pki/server/deployment/pkiparser.py and in base/common/python/pki/key.py, you solve the import problem for urllib by trying to import the Python2 first and then Python 3 (or visa versa). Why doesn't importing the relevant six module work instead? And on patch 14 (sepolgen): 3. Could you explain what the effect of your sepolgen change is? Please co-ordinate checkins with Matt. Ade On Fri, 2015-08-14 at 17:03 +0200, Christian Heimes wrote:
And now with attachment.
I also attached a 2nd patch that fixes the one unit test under Python 3.
Christian
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel