New patch attached. It has been rebased against the latest. On 1/14/2012 12:12 AM, John Magne wrote:
The following construct below originally looked odd, but upon further review online, it appears that this is a generic method where the "<V>" at the front denotes a type. This is legitimate but it looks like this getExtDataInHashtable is used extensively, it would be nice to know if we've done some simple testing to see if this works as expected.
- public Hashtable getExtDataInHashtable(String key); + public<V> Hashtable<String, V> getExtDataInHashtable(String key);
As suggested by Adam last week, I replaced this with: public Hashtable<String, Object> getExtDataInHashtable(String key);
Somehow in rifling through 10,000 lines I picked out this below:
CertificatePoliciesExtDefault.java
- Vector infos = null; + Vector<CertificatePolicyInfo> infos;
Looks like we didn't set info to null here:
I think the following code will set the infos, or set it to null if there's an exception, so the null initialization is not necessary.
Otherwise I think that it comes down to how much simple testing have we done to make sure extensions still work as expected? I noticed the unit testing and that's great.
I did a smoke test and didn't find any problems, but I'm not sure how to test specific changes that were made in this patch. Do you have any suggestions? -- Endi S. Dewata
----- Original Message ----- From: "Endi Sukma Dewata"<edewata@redhat.com> To: pki-devel@redhat.com Sent: Friday, January 13, 2012 7:53:22 AM Subject: [Pki-devel] [PATCH] 11 Added generics (part 1).
This patch is based on Adam's patch. It brings down the warnings from 6137 to 4656.
Ticket #2
http://fedorapeople.org/gitweb?p=edewata/public_git/pki.git;a=commitdiff;h=0...