ACK for 19-1 Based on review and testing of original patch. ----- Original Message ----- From: "Endi Sukma Dewata" <edewata@redhat.com> To: pki-devel@redhat.com Sent: Wednesday, February 22, 2012 9:22:43 AM Subject: Re: [Pki-devel] [PATCH] 18-19 Consolidated BtoA/AtoB invocations. On 2/21/2012 10:29 AM, Endi Sukma Dewata wrote:
The OSUtil.BtoA() and OSUtil.AtoB() have been replaced with wrapper methods in com.netscape.cmsutil.util.Utils that call Base64 encoder and decoder from Apache Commons Codec library.
Ticket #90
Attached are the old patch #18 and a new patch #19-1. I've split the old patch #19 into #19-1 and #20 (which will be submitted separately). Patch #19-1 is for consolidating the invocations, it's still using OSUtil. Patch #20 is for replacing it with Apache codec. http://fedorapeople.org/gitweb?p=edewata/public_git/pki.git;a=shortlog;h=ref... Passed smoke test. -- Endi S. Dewata _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel