Re: [Pki-devel] [PATCH] 192 Removed RA and TPS theme packages.

On 11/30/2012 12:25 AM, Ade Lee wrote: Are you referring to the removal of this code? chmod 755 %{buildroot}%{_datadir}/pki/tps-ui/cgi-bin/sow/cfg.pl There are codes in pkicreate:2076-2090 that set the permissions: set_permissions("${cgibin_instance_path}/sow/*.pl", $default_exe_permissions); So the above chmod code is not necessary. This is discussed in my response for #190. The original code already has some codes to copy the subsystem theme files and common theme files (see pkicreate:2064): # Copy /usr/share/pki/<ra/tps>-ui to <instance> return 0 if !copy_directory($ui_subsystem_path, $pki_instance_path, $default_dir_permissions, $default_file_permissions, $pki_user, $pki_group); # Copy /usr/share/pki/common-ui to <instance>/docroot/pki return 0 if !copy_directory( $common_ui_subsystem_path, "$docroot_instance_path/pki", $default_dir_permissions, $default_file_permissions, $pki_user, $pki_group); In the attached revised patch the code to copy <ra/tps>-ui has been removed because the RA/TPS themes don't exist anymore. The copy_directory() would ignore missing folders, but it's better to remove unused code. The code to copy the common-ui is left intact. Yes, the UI seems to be working fine, I didn't see any broken page/links/images, but I'm not familiar with these subsystems to test the functionality. Yes, they seem to be deployed to the same locations. Yes, they looked fine. No, I'm not familiar with this UI, please let me know how to test it. -- Endi S. Dewata