[PATCH] 23 Fixes for READ_OBJECT_SYNC, WRITE_TO_STATIC_FIELD and some Miscellaneous cases in Coverty for DogTag 10
Please review the attached patch with fixes for the remaining issues in Coverity. --Abhishek Koneru
On 7/13/2012 12:39 PM, Abhishek Koneru wrote:
Please review the attached patch with fixes for the remaining issues in Coverity.
A few comments: 1. In CMSEngine.java please move the mServerCertNickname definition next to the other non-static members. 2. In CertUtils.java:845 the certusage could be null so you might want to check for both conditions: if (certusage == null || certusage.equals("")) 3. In GenericASN1Extension.java the class has 3 constructors. In the first two it sets the mConfig with the value from the parameter. However, in the last constructor the mConfig is not set. In the original code the mConfig is static, so the value depends on the execution of the first 2 constructors. This is not a good programming practice, but if we convert it to non-static a code using the third constructor may fail because the mConfig will always be null. I'd suggest we fix this in a separate ticket. -- Endi S. Dewata
Please review the patch 23-2 with fixes for review comments given for Patch 23. --Abhishek Koneru On Tue, 2012-07-17 at 11:39 -0500, Endi Sukma Dewata wrote:
On 7/13/2012 12:39 PM, Abhishek Koneru wrote:
Please review the attached patch with fixes for the remaining issues in Coverity.
A few comments:
1. In CMSEngine.java please move the mServerCertNickname definition next to the other non-static members.
2. In CertUtils.java:845 the certusage could be null so you might want to check for both conditions:
if (certusage == null || certusage.equals(""))
3. In GenericASN1Extension.java the class has 3 constructors. In the first two it sets the mConfig with the value from the parameter. However, in the last constructor the mConfig is not set. In the original code the mConfig is static, so the value depends on the execution of the first 2 constructors. This is not a good programming practice, but if we convert it to non-static a code using the third constructor may fail because the mConfig will always be null. I'd suggest we fix this in a separate ticket.
On 7/18/2012 9:43 AM, Abhishek Koneru wrote:
Please review the patch 23-2 with fixes for review comments given for Patch 23.
ACK. Merged and pushed to master. -- Endi S. Dewata
participants (2)
-
Abhishek Koneru -
Endi Sukma Dewata