[PATCH] 0070 Use correct textual encoding for PKCS #7 objects
Hi all, Pursuant to RFC 7468 the attached patch replaces instances of 'CERTIFICATE CHAIN' in PEM headers with 'PKCS7'. Fixes ticket https://fedorahosted.org/pki/ticket/1699. I could not reproduce any problems with `keytool' as mentioned in the ticket, nor find cases online of programs supporting 'CERTIFICATE CHAIN' but not 'PKCS7', so I think this is a good change to make. We can address counterexamples if/when we have hard evidence of them :) Cheers, Fraser
On 1/13/2016 1:37 AM, Fraser Tweedale wrote:
Hi all,
Pursuant to RFC 7468 the attached patch replaces instances of 'CERTIFICATE CHAIN' in PEM headers with 'PKCS7'.
Fixes ticket https://fedorahosted.org/pki/ticket/1699. I could not reproduce any problems with `keytool' as mentioned in the ticket, nor find cases online of programs supporting 'CERTIFICATE CHAIN' but not 'PKCS7', so I think this is a good change to make. We can address counterexamples if/when we have hard evidence of them :)
Cheers, Fraser
In CryptoUtil you probably could use replaceAll to remove the whitespaces too. Regardless, it's ACKed. -- Endi S. Dewata
On Thu, Feb 11, 2016 at 09:59:04PM -0600, Endi Sukma Dewata wrote:
On 1/13/2016 1:37 AM, Fraser Tweedale wrote:
Hi all,
Pursuant to RFC 7468 the attached patch replaces instances of 'CERTIFICATE CHAIN' in PEM headers with 'PKCS7'.
Fixes ticket https://fedorahosted.org/pki/ticket/1699. I could not reproduce any problems with `keytool' as mentioned in the ticket, nor find cases online of programs supporting 'CERTIFICATE CHAIN' but not 'PKCS7', so I think this is a good change to make. We can address counterexamples if/when we have hard evidence of them :)
Cheers, Fraser
In CryptoUtil you probably could use replaceAll to remove the whitespaces too. Regardless, it's ACKed.
Thanks! Pushed to master (f6177fede9d1b688f0519953ec14839d513a6e2c)
participants (2)
-
Endi Sukma Dewata -
Fraser Tweedale