[PATCH] 844 Fixed CryptoUtil.getTokenName().
The CryptoUtil.getTokenName() has been modified to check both the short name and full name of the internal token. The ConfigurationUtils.deleteCert() has also been modified to call CryptoUtil.getTokenName(). https://fedorahosted.org/pki/ticket/2500 Pushed to master under one-liner/trivial rule. -- Endi S. Dewata
Code looks good. ACK if tested to work in both FIPS and non-FIPS, with or without HSM. Might be a future exercise to find out where the string "Internal Key Storage Token" comes from. Christina On 10/13/2016 06:57 PM, Endi Sukma Dewata wrote:
The CryptoUtil.getTokenName() has been modified to check both the short name and full name of the internal token.
The ConfigurationUtils.deleteCert() has also been modified to call CryptoUtil.getTokenName().
https://fedorahosted.org/pki/ticket/2500
Pushed to master under one-liner/trivial rule.
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On 10/18/2016 11:34 AM, Christina Fu wrote:
Code looks good. ACK if tested to work in both FIPS and non-FIPS, with or without HSM.
Might be a future exercise to find out where the string "Internal Key Storage Token" comes from.
Christina
Thanks! It works in the above cases. The patch has already been pushed to master. -- Endi S. Dewata
participants (2)
-
Christina Fu -
Endi Sukma Dewata