addressed comments and pushed per conditional ACK: commit 3f14aa5c6a29170eedfc5a04b863bd7d13a03f34 thanks, Christina On 09/05/2014 11:25 AM, John Magne wrote:

ACK, with an explanation:

Also received a demo of this fix.

This looks ok. Also this change is not that invasive and makes sense.

Here we simply want to have the list of cert db reflect accurately what is on the token.

Minor: We might want to change the message in the off case the initial "cert purge" happens. The legit reason to move is possibly the token had no certs previously.

Just make the message more clear as to what is going on, instead of listing a method name that the reader may not connect to the actual issue.

----- Original Message ----- From: "Christina Fu" <cfu@redhat.com> To: pki-devel@redhat.com Sent: Friday, September 5, 2014 11:20:06 AM Subject: [Pki-devel] [PATCH] pki-cfu-0035-Ticket-882-remove-all-certs-belong-to-a-token-before.patch

Previously, we just add certs to to the tokendb as we enroll. This patch cleans up the certs belong to a token before adding them. It will reflect what's on the token more truthfully.

thanks, Christina

_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel