[PATCH] 84 Change the return type of retrieve_key(key_id, twsk) in KeyClient (python)
The initial return of type tuple [KeyData, unwrapped_key] is replaced by returning just the KeyData object. The unwrapped key will be set as attribute 'private_data' of the KeyData object. Please review the attached patch with the above mentioned changes. --Abhishek
ACK - with the following caveats. 1. in key.py, add a blank line before # To store the unwrapped ... 2. The logic in retrieve_key() can be condensed : if not key_provided: unwrapped_key = self.crypto.symmetric_unwrap( key_data.wrappedPrivateData, session_key, nonce_iv=key_data.nonceData) key_data.private_data = unwrapped_key return key_data 3. There is a test that has been added to the end of drmtest.py that uses retrieve_key. It needs to be modified. Make sure to run through drmtest.py once again to confirm that it all works. Ade On Mon, 2014-03-03 at 08:31 -0500, Abhishek Koneru wrote:
The initial return of type tuple [KeyData, unwrapped_key] is replaced by returning just the KeyData object. The unwrapped key will be set as attribute 'private_data' of the KeyData object.
Please review the attached patch with the above mentioned changes.
--Abhishek _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
Addressed Ade's comments. In addition to those, also committed a fix for the failing approve/reject/cancel request calls due to wrong connection.post method calls and added a catch to Test 2 in drmtest.py, since it will fail for a new instance. --Abhishek On Wed, 2014-03-05 at 12:34 -0500, Ade Lee wrote:
ACK - with the following caveats.
1. in key.py, add a blank line before # To store the unwrapped ... 2. The logic in retrieve_key() can be condensed :
if not key_provided: unwrapped_key = self.crypto.symmetric_unwrap( key_data.wrappedPrivateData, session_key, nonce_iv=key_data.nonceData) key_data.private_data = unwrapped_key return key_data
3. There is a test that has been added to the end of drmtest.py that uses retrieve_key. It needs to be modified.
Make sure to run through drmtest.py once again to confirm that it all works.
Ade
On Mon, 2014-03-03 at 08:31 -0500, Abhishek Koneru wrote:
The initial return of type tuple [KeyData, unwrapped_key] is replaced by returning just the KeyData object. The unwrapped key will be set as attribute 'private_data' of the KeyData object.
Please review the attached patch with the above mentioned changes.
--Abhishek _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (2)
-
Abhishek Koneru -
Ade Lee