[PATCH] typesafety patches - Pki-devel - Dogtag Pki List Archives

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

[PATCH] typesafety patches

[PATCH] more typesafety changes

[PATCH] 7 Fixed PKI_COMPONENT_LIST...

Adam Young

Thursday, 22 December 2011 Thu, 22 Dec '11

12:08 p.m.

These have been rebased on top of master and might conflict with previously submitted patches. These should all all be relatively independent, but it is possible that some of the later patches require earlier patches in order to apply. Please indicate the patch number in any ACK/NACK messages.

Attachments:

dogtag-admiyo-0038-type-safety-for-certserv.base.patch (text/x-patch — 56.6 KB)
dogtag-admiyo-0037-type-safety-for-certserv.authorization.patch (text/x-patch — 17.5 KB)
dogtag-admiyo-0036-type-safety-for-certserv.authenticator.patch (text/x-patch — 10.2 KB)
dogtag-admiyo-0035-Type-safety-for-CMS-and-by-extension-much-of-common.patch (text/x-patch — 34.1 KB)
dogtag-admiyo-0034-Type-safety-for-ACLs.patch (text/x-patch — 5.3 KB)
dogtag-admiyo-0033-type-safety-cleanup-in-common.patch (text/x-patch — 9.2 KB)
dogtag-admiyo-0032-util-type-safety-cleanup.patch (text/x-patch — 58.9 KB)
dogtag-admiyo-0031-Unreachable-Catch-clauses.patch (text/x-patch — 7.3 KB)
dogtag-admiyo-0030-TreeSet.patch (text/x-patch — 3.2 KB)
dogtag-admiyo-0029-gitignore.patch (text/x-patch — 896 bytes)
dogtag-admiyo-0028-Removal-of-unused-private-methods.patch (text/x-patch — 3.2 KB)

Reply

Show replies by date

Ade Lee

Thursday, 22 December Thu, 22 Dec

2:22 p.m.

28 - ACK 29 - ACK 30 - ACK - but change the description. This has nothing to do with TreeSet 31 - ACK 32 - For the most part - ACK. RevokedCertImpl.java looks like it has been reformatted though -- which is obscuring the real changes in the file. Please resubmit with just the relevant changes in that file. Continuing with the rest .. Ade On Thu, 2011-12-22 at 13:08 -0500, Adam Young wrote:

These have been rebased on top of master and might conflict with previously submitted patches. These should all all be relatively independent, but it is possible that some of the later patches require earlier patches in order to apply. Please indicate the patch number in any ACK/NACK messages. _______________________________________________ Pki-devel mailing list Pki-devel(a)redhat.com https://www.redhat.com/mailman/listinfo/pki-devel

Reply

Ade Lee

3:01 p.m.

33 - ACK 34 - ACK 35 - ACK 36- ACK 37 - ACK 38 - In AuthAdminServlet.java , a suppress warnings annotation is placed before addAuthMgrPlugin(). Can it be moved closer to the code causing the warnings? - Why has the return for the put() method in SourceConfigStore and PropConfigStore (and the corresponding interfaces been changed from void to string? What is supposed to be returned here? Ade On Thu, 2011-12-22 at 15:22 -0500, Ade Lee wrote:

28 - ACK 29 - ACK 30 - ACK - but change the description. This has nothing to do with TreeSet 31 - ACK 32 - For the most part - ACK. RevokedCertImpl.java looks like it has been reformatted though -- which is obscuring the real changes in the file. Please resubmit with just the relevant changes in that file. Continuing with the rest .. Ade On Thu, 2011-12-22 at 13:08 -0500, Adam Young wrote: > These have been rebased on top of master and might conflict with > previously submitted patches. These should all all be relatively > independent, but it is possible that some of the later patches require > earlier patches in order to apply. Please indicate the patch number in > any ACK/NACK messages. > _______________________________________________ > Pki-devel mailing list > Pki-devel(a)redhat.com > https://www.redhat.com/mailman/listinfo/pki-devel _______________________________________________ Pki-devel mailing list Pki-devel(a)redhat.com https://www.redhat.com/mailman/listinfo/pki-devel

Reply

Adam Young

3:41 p.m.

On 12/22/2011 04:01 PM, Ade Lee wrote:

33 - ACK 34 - ACK 35 - ACK 36- ACK 37 - ACK 38 - In AuthAdminServlet.java , a suppress warnings annotation is placed before addAuthMgrPlugin(). Can it be moved closer to the code causing the warnings?

Yep.. done

- Why has the return for the put() method in SourceConfigStore and PropConfigStore (and the corresponding interfaces been changed from void to string? What is supposed to be returned here?

SourceConfigStore extends SimpleProperties SimpleProperties extends Hashtable<String,String> So it has to return a string. Config is basically properties files: string to string.

Ade On Thu, 2011-12-22 at 15:22 -0500, Ade Lee wrote: > 28 - ACK > 29 - ACK > 30 - ACK - but change the description. This has nothing to do with > TreeSet

Will change it to "type safety in CMSCRLExtensions and PublisherProcessor"

> 31 - ACK > 32 - For the most part - ACK. RevokedCertImpl.java looks like it has > been reformatted though -- which is obscuring the real changes in the > file. Please resubmit with just the relevant changes in that file.

Resubmitted

> > Continuing with the rest .. > > Ade > > On Thu, 2011-12-22 at 13:08 -0500, Adam Young wrote: >> These have been rebased on top of master and might conflict with >> previously submitted patches. These should all all be relatively >> independent, but it is possible that some of the later patches require >> earlier patches in order to apply. Please indicate the patch number in >> any ACK/NACK messages. >> _______________________________________________ >> Pki-devel mailing list >> Pki-devel(a)redhat.com >> https://www.redhat.com/mailman/listinfo/pki-devel > > _______________________________________________ > Pki-devel mailing list > Pki-devel(a)redhat.com > https://www.redhat.com/mailman/listinfo/pki-devel

Reply

Adam Young

4:18 p.m.

On 12/22/2011 04:41 PM, Adam Young wrote:

On 12/22/2011 04:01 PM, Ade Lee wrote: > 33 - ACK > 34 - ACK > 35 - ACK > 36- ACK > 37 - ACK > 38 > - In AuthAdminServlet.java , a suppress warnings annotation is placed > before addAuthMgrPlugin(). Can it be moved closer to the code causing > the warnings? Yep.. done > - Why has the return for the put() method in SourceConfigStore and > PropConfigStore (and the corresponding interfaces been changed from void > to string? What is supposed to be returned here? SourceConfigStore extends SimpleProperties SimpleProperties extends Hashtable<String,String> So it has to return a string. Config is basically properties files: string to string. > > Ade > > On Thu, 2011-12-22 at 15:22 -0500, Ade Lee wrote: >> 28 - ACK >> 29 - ACK >> 30 - ACK - but change the description. This has nothing to do with >> TreeSet Will change it to "type safety in CMSCRLExtensions and PublisherProcessor" >> 31 - ACK >> 32 - For the most part - ACK. RevokedCertImpl.java looks like it has >> been reformatted though -- which is obscuring the real changes in the >> file. Please resubmit with just the relevant changes in that file. Resubmitted >> >> Continuing with the rest .. >> >> Ade >> >> On Thu, 2011-12-22 at 13:08 -0500, Adam Young wrote: >>> These have been rebased on top of master and might conflict with >>> previously submitted patches. These should all all be relatively >>> independent, but it is possible that some of the later patches >>> require >>> earlier patches in order to apply. Please indicate the patch >>> number in >>> any ACK/NACK messages. >>> _______________________________________________ >>> Pki-devel mailing list >>> Pki-devel(a)redhat.com >>> https://www.redhat.com/mailman/listinfo/pki-devel >> >> _______________________________________________ >> Pki-devel mailing list >> Pki-devel(a)redhat.com >> https://www.redhat.com/mailman/listinfo/pki-devel > _______________________________________________ Pki-devel mailing list Pki-devel(a)redhat.com https://www.redhat.com/mailman/listinfo/pki-devel

Final ACK in IRC by Ade Lee. Pushed to master

Reply

4507

days inactive

4507

days old

devel@lists.dogtagpki.org

Manage subscription

4 comments

2 participants

tags (0)

participants (2)

Adam Young
Ade Lee