Re: [Pki-devel] [PATCH] 152 - catch all exceptions when checking status.
Ok - last take. this is better. On Thu, 2013-09-05 at 23:10 -0400, Ade Lee wrote:
phooey -- try attached patch.
\On Thu, 2013-09-05 at 22:15 -0400, John Magne wrote:
I recompiled with your patch and reinstalled. My TPS install still failed here is the end of the trace:
2013-09-05 19:09:34 pkispawn : INFO ....... executing 'systemctl restart pki-tomcatd@pki-tomcat.service' 2013-09-05 19:09:36 pkispawn : DEBUG ........... No connection - server may still be down 2013-09-05 19:09:36 pkispawn : DEBUG ....... Error Type: TypeError 2013-09-05 19:09:36 pkispawn : DEBUG ....... Error Message: cannot concatenate 'str' and 'type' objects 2013-09-05 19:09:36 pkispawn : DEBUG ....... File "/usr/sbin/pkispawn", line 373, in main rv = instance.spawn(deployer) File "/usr/lib/python2.7/site-packages/pki/server/deployment/scriptlets/configuration.py", line 98, in spawn status = deployer.instance.wait_for_startup(60) File "/usr/lib/python2.7/site-packages/pki/server/deployment/pkihelper.py", line 1062, in wait_for_startup status = self.get_instance_status() File "/usr/lib/python2.7/site-packages/pki/server/deployment/pkihelper.py", line 1054, in get_instance_status config.pki_log.debug("No connection - exception thrown: " + sys.exc_info()[0],
----- Original Message ----- From: "Ade Lee" <alee@redhat.com> To: "John Magne" <jmagne@redhat.com> Sent: Thursday, September 5, 2013 6:30:21 PM Subject: Re: Fwd: [Pki-devel] [PATCH] 152 - catch all exceptions when checking status.
Looks like pylint 1.0 added some new warnings. I have fixed the relevant code and added it to the patch.
Please use this patch instead. Ade
On Thu, 2013-09-05 at 18:35 -0400, John Magne wrote:
I forgot to add that I'm on F19.
----- Forwarded Message ----- From: "John Magne" <jmagne@redhat.com> To: alee@redhat.com Sent: Thursday, September 5, 2013 3:20:58 PM Subject: Re: [Pki-devel] [PATCH] 152 - catch all exceptions when checking status.
Hey Ade:
I was working on this . After installing the patch I attempted to do a build of pki-core, but it rejected me big time. The pylint step was complaining about "Errors or Warning" and pointed me to some very long log file. Looks like there were no errors but some new warnings maybe? Can you take a look? I certainly want to actually compile and install/test this thing before giving it the full thumbs up.
Attached is my endless pylinst log file.
----- Original Message ----- From: "Ade Lee" <alee@redhat.com> To: pki-devel@redhat.com Sent: Thursday, September 5, 2013 2:09:03 PM Subject: [Pki-devel] [PATCH] 152 - catch all exceptions when checking status.
Catch all exceptions when checking for status.
python-requests now throws a ProxyError if the server is not yet up. Previously only connect exceptions were seen. To ensure that we are not broken again when python-requests and the underlying libraries are changed, we will catch and log all exceptions. If the connection ultimately fails, we will time out in any case.
Ticket 717
Please review.
Thanks, Ade
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
ACK: Actually tried this out on my F19 box that has the latest python request and url packages that revealed the issue to us originally. Looks and works fine. ----- Original Message ----- From: "Ade Lee" <alee@redhat.com> To: "John Magne" <jmagne@redhat.com> Cc: pki-devel@redhat.com Sent: Friday, September 6, 2013 1:32:19 PM Subject: Re: [Pki-devel] [PATCH] 152 - catch all exceptions when checking status. Ok - last take. this is better. On Thu, 2013-09-05 at 23:10 -0400, Ade Lee wrote:
phooey -- try attached patch.
\On Thu, 2013-09-05 at 22:15 -0400, John Magne wrote:
I recompiled with your patch and reinstalled. My TPS install still failed here is the end of the trace:
2013-09-05 19:09:34 pkispawn : INFO ....... executing 'systemctl restart pki-tomcatd@pki-tomcat.service' 2013-09-05 19:09:36 pkispawn : DEBUG ........... No connection - server may still be down 2013-09-05 19:09:36 pkispawn : DEBUG ....... Error Type: TypeError 2013-09-05 19:09:36 pkispawn : DEBUG ....... Error Message: cannot concatenate 'str' and 'type' objects 2013-09-05 19:09:36 pkispawn : DEBUG ....... File "/usr/sbin/pkispawn", line 373, in main rv = instance.spawn(deployer) File "/usr/lib/python2.7/site-packages/pki/server/deployment/scriptlets/configuration.py", line 98, in spawn status = deployer.instance.wait_for_startup(60) File "/usr/lib/python2.7/site-packages/pki/server/deployment/pkihelper.py", line 1062, in wait_for_startup status = self.get_instance_status() File "/usr/lib/python2.7/site-packages/pki/server/deployment/pkihelper.py", line 1054, in get_instance_status config.pki_log.debug("No connection - exception thrown: " + sys.exc_info()[0],
----- Original Message ----- From: "Ade Lee" <alee@redhat.com> To: "John Magne" <jmagne@redhat.com> Sent: Thursday, September 5, 2013 6:30:21 PM Subject: Re: Fwd: [Pki-devel] [PATCH] 152 - catch all exceptions when checking status.
Looks like pylint 1.0 added some new warnings. I have fixed the relevant code and added it to the patch.
Please use this patch instead. Ade
On Thu, 2013-09-05 at 18:35 -0400, John Magne wrote:
I forgot to add that I'm on F19.
----- Forwarded Message ----- From: "John Magne" <jmagne@redhat.com> To: alee@redhat.com Sent: Thursday, September 5, 2013 3:20:58 PM Subject: Re: [Pki-devel] [PATCH] 152 - catch all exceptions when checking status.
Hey Ade:
I was working on this . After installing the patch I attempted to do a build of pki-core, but it rejected me big time. The pylint step was complaining about "Errors or Warning" and pointed me to some very long log file. Looks like there were no errors but some new warnings maybe? Can you take a look? I certainly want to actually compile and install/test this thing before giving it the full thumbs up.
Attached is my endless pylinst log file.
----- Original Message ----- From: "Ade Lee" <alee@redhat.com> To: pki-devel@redhat.com Sent: Thursday, September 5, 2013 2:09:03 PM Subject: [Pki-devel] [PATCH] 152 - catch all exceptions when checking status.
Catch all exceptions when checking for status.
python-requests now throws a ProxyError if the server is not yet up. Previously only connect exceptions were seen. To ensure that we are not broken again when python-requests and the underlying libraries are changed, we will catch and log all exceptions. If the connection ultimately fails, we will time out in any case.
Ticket 717
Please review.
Thanks, Ade
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (2)
-
Ade Lee -
John Magne