[PATCH] pki-cfu-0107-Ticket-1527-TPS-connector-always-goes-to-ca1.patch
this patch fixes the issue reported in: https://fedorahosted.org/pki/ticket/1527 TPS Enrollment always goes to "ca1" It has been tested on both format and enrollment operations to work. One thing to note is that there is no longer a default ca "ca1" if the configuration is missing. I think it should be done this way as the configuration is expected to be done correctly and the program will then find the setting. thanks, Christina
now with the patch. On 10/26/2015 05:46 PM, Christina Fu wrote:
this patch fixes the issue reported in: https://fedorahosted.org/pki/ticket/1527 TPS Enrollment always goes to "ca1"
It has been tested on both format and enrollment operations to work. One thing to note is that there is no longer a default ca "ca1" if the configuration is missing. I think it should be done this way as the configuration is expected to be done correctly and the program will then find the setting.
thanks, Christina
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
This looks nice. It enforces that the value is present or else it throws an exception. Also the exception prints out the config value we were trying to find. ACK One thing to keep an eye on is to make sure our other connectors are behaving as we polish TPS. ----- Original Message ----- From: "Christina Fu" <cfu@redhat.com> To: "pki-devel" <pki-devel@redhat.com> Sent: Tuesday, October 27, 2015 10:21:56 AM Subject: Re: [Pki-devel] [PATCH] pki-cfu-0107-Ticket-1527-TPS-connector-always-goes-to-ca1.patch now with the patch. On 10/26/2015 05:46 PM, Christina Fu wrote:
this patch fixes the issue reported in: https://fedorahosted.org/pki/ticket/1527 TPS Enrollment always goes to "ca1"
It has been tested on both format and enrollment operations to work. One thing to note is that there is no longer a default ca "ca1" if the configuration is missing. I think it should be done this way as the configuration is expected to be done correctly and the program will then find the setting.
thanks, Christina
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
pushed to master: commit 74197061be89f650f6bc10f0887ab1c87470272e thanks, Christina On 10/27/2015 10:56 AM, John Magne wrote:
This looks nice.
It enforces that the value is present or else it throws an exception. Also the exception prints out the config value we were trying to find.
ACK
One thing to keep an eye on is to make sure our other connectors are behaving as we polish TPS.
----- Original Message ----- From: "Christina Fu" <cfu@redhat.com> To: "pki-devel" <pki-devel@redhat.com> Sent: Tuesday, October 27, 2015 10:21:56 AM Subject: Re: [Pki-devel] [PATCH] pki-cfu-0107-Ticket-1527-TPS-connector-always-goes-to-ca1.patch
now with the patch.
On 10/26/2015 05:46 PM, Christina Fu wrote:
this patch fixes the issue reported in: https://fedorahosted.org/pki/ticket/1527 TPS Enrollment always goes to "ca1"
It has been tested on both format and enrollment operations to work. One thing to note is that there is no longer a default ca "ca1" if the configuration is missing. I think it should be done this way as the configuration is expected to be done correctly and the program will then find the setting.
thanks, Christina
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (2)
-
Christina Fu -
John Magne