[Patch] pki-vakwetu-0007-Added-initial-code-for-retrieving-transport-cert.patch
Added code to get transport cert through restful interface. This uses conditional-GET logic which will only return content if the transport cert has changed - which is fairly unlikely. Plase review. Ade
Rebased patch .. On Mon, 2012-01-09 at 11:17 -0500, Ade Lee wrote:
Added code to get transport cert through restful interface. This uses conditional-GET logic which will only return content if the transport cert has changed - which is fairly unlikely.
Plase review.
Ade
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
Based on review comments from jmagne, made the following changes: * check for null pointers in SystemCertificateResource * move logic from CertificatData constructor to CMSServlet builder method * remove unused field uriInfo and replace hard-coded cache constant New patch attached. Please review. Ade On Thu, 2012-01-12 at 20:49 -0500, Ade Lee wrote:
Rebased patch ..
On Mon, 2012-01-09 at 11:17 -0500, Ade Lee wrote:
Added code to get transport cert through restful interface. This uses conditional-GET logic which will only return content if the transport cert has changed - which is fairly unlikely.
Plase review.
Ade
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
Based on comments from Endi, changes made: We no longer inherit from CMSServlet, but rather from CMSResource. Ade On Fri, 2012-01-13 at 11:37 -0500, Ade Lee wrote:
Based on review comments from jmagne, made the following changes:
* check for null pointers in SystemCertificateResource * move logic from CertificatData constructor to CMSServlet builder method * remove unused field uriInfo and replace hard-coded cache constant
New patch attached. Please review.
Ade
On Thu, 2012-01-12 at 20:49 -0500, Ade Lee wrote:
Rebased patch ..
On Mon, 2012-01-09 at 11:17 -0500, Ade Lee wrote:
Added code to get transport cert through restful interface. This uses conditional-GET logic which will only return content if the transport cert has changed - which is fairly unlikely.
Plase review.
Ade
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
ACKed by Endi with small formatting changes - pushed to master. On Fri, 2012-01-13 at 14:47 -0500, Ade Lee wrote:
Based on comments from Endi, changes made: We no longer inherit from CMSServlet, but rather from CMSResource.
Ade On Fri, 2012-01-13 at 11:37 -0500, Ade Lee wrote:
Based on review comments from jmagne, made the following changes:
* check for null pointers in SystemCertificateResource * move logic from CertificatData constructor to CMSServlet builder method * remove unused field uriInfo and replace hard-coded cache constant
New patch attached. Please review.
Ade
On Thu, 2012-01-12 at 20:49 -0500, Ade Lee wrote:
Rebased patch ..
On Mon, 2012-01-09 at 11:17 -0500, Ade Lee wrote:
Added code to get transport cert through restful interface. This uses conditional-GET logic which will only return content if the transport cert has changed - which is fairly unlikely.
Plase review.
Ade
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (1)
-
Ade Lee