Please review the attached patch.
On Fri, 2013-03-22 at 10:32 -0500, Endi Sukma Dewata wrote:
On 3/22/2013 10:16 AM, Abhishek Koneru wrote:
> Please review the attached patch which adds a -W <security domain
> password file> option replacing the -w <security domain password file>
> option in pkidestroy.
1. Please add a short subject line in the comment like the other patches.
the subject line.
2. Let's use the US spelling 'canceled' as explained in the other patch.
3. Could you find out what the strip('[\']') is used for?
In any case,
the original code strips those characters from the password. The new
code strips those characters from the file name, not the password.
Not required when password is input using a file.
4. Please use 'with' to open the file. See:
Used the with construct for file reading.