[PATCH] 22 Fixes for USE_HASHCODE , RETURN_VALUE_IGNORED and ARITHMETIC operator related issues for DogTag 10 in Coverity
Please review the attached patch with fixes for USE_HASHCODE , RETURN_VALUE_IGNORED and arithmetic and logical operator errors for DogTag 10 in Coverity(Issues 11646-11655,11660,11663). Build passed the smoke test. --Abhishek Koneru
Sorry for the spam. Last patch had some errors when applied. Please review the attached patch. --Abhishek Koneru On Tue, 2012-07-10 at 17:25 -0400, Abhishek Koneru wrote:
Please review the attached patch with fixes for USE_HASHCODE , RETURN_VALUE_IGNORED and arithmetic and logical operator errors for DogTag 10 in Coverity(Issues 11646-11655,11660,11663).
Build passed the smoke test.
--Abhishek Koneru _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
Patch 22 with a minor fix related to hash function. Please ignore the previous patches and review this one. --Abhishek Koneru On Wed, 2012-07-11 at 15:31 -0400, Abhishek Koneru wrote:
Sorry for the spam. Last patch had some errors when applied. Please review the attached patch.
--Abhishek Koneru
On Tue, 2012-07-10 at 17:25 -0400, Abhishek Koneru wrote:
Please review the attached patch with fixes for USE_HASHCODE , RETURN_VALUE_IGNORED and arithmetic and logical operator errors for DogTag 10 in Coverity(Issues 11646-11655,11660,11663).
Build passed the smoke test.
--Abhishek Koneru _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
1. In FileBasedPublisher.java, there are lots of places where we do file operations and then just log the return code if the operation fails. This really isn't the best way to do this. It would be better to rewrite the code to use the Files class in Java 7 - so that failure of these types of operations would result in exceptions being thrown. Therefore, I would not fix these - and rather defer till coverity can handle Java 7. 2. In CMSEngine, we just log the error if the file operation fails. We should be throwing an EBaseException. Also, the check if the file exists is superfluous. And the IOException should be caught and rethrown as an EBaseException. The rest looks OK. Ade On Wed, 2012-07-11 at 15:43 -0400, Abhishek Koneru wrote:
Patch 22 with a minor fix related to hash function. Please ignore the previous patches and review this one.
--Abhishek Koneru
On Wed, 2012-07-11 at 15:31 -0400, Abhishek Koneru wrote:
Sorry for the spam. Last patch had some errors when applied. Please review the attached patch.
--Abhishek Koneru
On Tue, 2012-07-10 at 17:25 -0400, Abhishek Koneru wrote:
Please review the attached patch with fixes for USE_HASHCODE , RETURN_VALUE_IGNORED and arithmetic and logical operator errors for DogTag 10 in Coverity(Issues 11646-11655,11660,11663).
Build passed the smoke test.
--Abhishek Koneru _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
Please review the patch which has the fixes for review comments given for PATCH 22. -- Abhishek Koneru On Thu, 2012-07-12 at 10:41 -0400, Ade Lee wrote:
2.
ack - pushed to master On Thu, 2012-07-12 at 11:11 -0400, Abhishek Koneru wrote:
Please review the patch which has the fixes for review comments given for PATCH 22.
-- Abhishek Koneru On Thu, 2012-07-12 at 10:41 -0400, Ade Lee wrote:
2.
participants (2)
-
Abhishek Koneru -
Ade Lee