[PATCH] 69 Last set of fixes for warnings and errors reported by pylint for Dogtag10.1 branch
Please review the patch with fixes for remaining two issues reported by pylint. 1. Attribute defined outside init. 2. Instance attribute hiding a class method (Ignored as the problem is in json.encoder.JSONEncoder). Also attached the final report. --Abhishek
ACK Extraneous E202 in comment in encoder class. As discussed, please add more description of the E202 problem in encoder.pl so we know why we are ignoring it. Ade On Wed, 2013-07-17 at 16:38 -0400, Abhishek Koneru wrote:
Please review the patch with fixes for remaining two issues reported by pylint.
1. Attribute defined outside init. 2. Instance attribute hiding a class method (Ignored as the problem is in json.encoder.JSONEncoder).
Also attached the final report.
--Abhishek _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
Added the description and removed the extraneous E0202 in the comment. Pushed to master. -Abhishek On Thu, 2013-07-18 at 10:47 -0400, Ade Lee wrote:
ACK
Extraneous E202 in comment in encoder class. As discussed, please add more description of the E202 problem in encoder.pl so we know why we are ignoring it.
Ade
On Wed, 2013-07-17 at 16:38 -0400, Abhishek Koneru wrote:
Please review the patch with fixes for remaining two issues reported by pylint.
1. Attribute defined outside init. 2. Instance attribute hiding a class method (Ignored as the problem is in json.encoder.JSONEncoder).
Also attached the final report.
--Abhishek _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (2)
-
Abhishek Koneru -
Ade Lee