[pki-devel][PATCH] 0042-TPS-add-phone-home-URLs-to-pkidaemon-status-message.patch
TPS add phone home URLs to pkidaemon status message. Ticket # 1466 . Also removed some needless copies of server.xml from the code. Related to ticket #773 - Remove legacy configuration files . . . Code verified in pycharm free of warnings. Tested with an upgrade to work fine. Also tested with a fresh install to make sure the proper entries show up in server.xml. Also tested the upgrade with a server.xml that already has the proper entries, the upgrade handles this case properly as well.
On 07/14/15 19:02, John Magne wrote:
TPS add phone home URLs to pkidaemon status message.
Ticket # 1466 .
Also removed some needless copies of server.xml from the code.
Related to ticket #773 - Remove legacy configuration files . . .
Code verified in pycharm free of warnings.
Tested with an upgrade to work fine. Also tested with a fresh install to make sure the proper entries show up in server.xml. Also tested the upgrade with a server.xml that already has the proper entries, the upgrade handles this case properly as well.
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel Verified with pycharm 4.5, and compiled successfully through the pylint gauntlet on F21.
ACK -- presuming that 'pkidaemon' displays the new TPS entries correctly.
my only request is that due to the removal of server.xml copies, regardless of the needlessness from observation, for safety, test at least a CA and KRA on separate tomcat instances (one successful enroll and archival will do). thanks, Christina On 07/14/2015 06:02 PM, John Magne wrote:
TPS add phone home URLs to pkidaemon status message.
Ticket # 1466 .
Also removed some needless copies of server.xml from the code.
Related to ticket #773 - Remove legacy configuration files . . .
Code verified in pycharm free of warnings.
Tested with an upgrade to work fine. Also tested with a fresh install to make sure the proper entries show up in server.xml. Also tested the upgrade with a server.xml that already has the proper entries, the upgrade handles this case properly as well.
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
Performed cfu's basic sanity test on separate instances, and they were good. Verified on my system that the old "server.xml" files were gone and could not interfere with the proceedings... Pushed tomaster. Closing ticket # 1466 . ----- Original Message -----
From: "Christina Fu" <cfu@redhat.com> To: pki-devel@redhat.com Sent: Wednesday, July 15, 2015 1:51:15 PM Subject: Re: [Pki-devel] [pki-devel][PATCH] 0042-TPS-add-phone-home-URLs-to-pkidaemon-status-message.patch
my only request is that due to the removal of server.xml copies, regardless of the needlessness from observation, for safety, test at least a CA and KRA on separate tomcat instances (one successful enroll and archival will do).
thanks, Christina
On 07/14/2015 06:02 PM, John Magne wrote:
TPS add phone home URLs to pkidaemon status message.
Ticket # 1466 .
Also removed some needless copies of server.xml from the code.
Related to ticket #773 - Remove legacy configuration files . . .
Code verified in pycharm free of warnings.
Tested with an upgrade to work fine. Also tested with a fresh install to make sure the proper entries show up in server.xml. Also tested the upgrade with a server.xml that already has the proper entries, the upgrade handles this case properly as well.
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (3)
-
Christina Fu -
John Magne -
Matthew Harmsen