[pki-devel][PATCH] 0069-Show-KeyOwner-info-when-viewing-recovery-requests.patch
Show KeyOwner info when viewing recovery requests. This simple fix will grab the subject info out of the cert associated with either pending or complete recovery requests being viewed in the KRA UI. For example: KeyOwner: UID=jmagne, O=Token Key User Will be displayed. Have seen this display for both pending and completed recovery requests. This simple fix should be good enough for this round, despite the bug asking about agent info and such. Those enhancements for later. Ticket : Ticket #1512 : Key owner info missing from the Search results of Recovery request
while the patch works, I think the original code logic is somehow flawed in a way that it uses the "profile" attribute to determine whether the request was non-TMS archival requests, and if null it treats it as TMS. It would make better sense if we add a separate case instead of lumping the handling of recovery requests inside where the TMS handling is at. thanks, Christina On 06/01/2016 03:13 PM, John Magne wrote:
Show KeyOwner info when viewing recovery requests.
This simple fix will grab the subject info out of the cert associated with either pending or complete recovery requests being viewed in the KRA UI.
For example:
KeyOwner: UID=jmagne, O=Token Key User
Will be displayed. Have seen this display for both pending and completed recovery requests.
This simple fix should be good enough for this round, despite the bug asking about agent info and such. Those enhancements for later.
Ticket : Ticket #1512 : Key owner info missing from the Search results of Recovery request
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
Pushed to master based on cfu's verbal conditional ACK for this (after I modded it the way she requested) Tested to work. commit 3cd58a98022141da2af4bf0bad29ab1dbdc86fbe Author: Jack Magne <jmagne@dhcp-16-206.sjc.redhat.com> Date: Wed Jun 1 15:05:20 2016 -0700 Closing ticket #1512 ----- Original Message -----
From: "Christina Fu" <cfu@redhat.com> To: pki-devel@redhat.com Sent: Friday, June 3, 2016 2:46:28 PM Subject: Re: [Pki-devel] [pki-devel][PATCH] 0069-Show-KeyOwner-info-when-viewing-recovery-requests.patch
while the patch works, I think the original code logic is somehow flawed in a way that it uses the "profile" attribute to determine whether the request was non-TMS archival requests, and if null it treats it as TMS. It would make better sense if we add a separate case instead of lumping the handling of recovery requests inside where the TMS handling is at.
thanks, Christina
On 06/01/2016 03:13 PM, John Magne wrote:
Show KeyOwner info when viewing recovery requests.
This simple fix will grab the subject info out of the cert associated with either pending or complete recovery requests being viewed in the KRA UI.
For example:
KeyOwner: UID=jmagne, O=Token Key User
Will be displayed. Have seen this display for both pending and completed recovery requests.
This simple fix should be good enough for this round, despite the bug asking about agent info and such. Those enhancements for later.
Ticket : Ticket #1512 : Key owner info missing from the Search results of Recovery request
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (2)
-
Christina Fu -
John Magne