[PATCH] 0066 Remove unused TOKEN_AUTHMGR_IMPL_NAME AuthToken attribute
On 1/11/2016 4:50 AM, Fraser Tweedale wrote:
Drive-by cleanup; patch attached.
Cheers, Fraser
Looks fine to me, ACK. Just a thought, instead of storing just the auth manager attributes in the token we probably could store the auth manager instance itself so we can access any methods on the auth manager. -- Endi S. Dewata
On Thu, Feb 11, 2016 at 08:59:31PM -0600, Endi Sukma Dewata wrote:
On 1/11/2016 4:50 AM, Fraser Tweedale wrote:
Drive-by cleanup; patch attached.
Cheers, Fraser
Looks fine to me, ACK.
Thanks! Pushed to master (0a21a687af947a4b9ed046673b7299d7a2da0710)
Just a thought, instead of storing just the auth manager attributes in the token we probably could store the auth manager instance itself so we can access any methods on the auth manager.
Treatment of tokens and auth manager attributes is currently inconsistent and a good candidate for refactoring, as time permits. Cheers, Fraser
participants (2)
-
Endi Sukma Dewata -
Fraser Tweedale