[PATCH] 21 Removed OS subsystem.
The OS subsystem was previously used to get the PID and to handle shutdown signals using the OSUtil. It has been removed because the functionalities can be obtained without using native code. The PID will now be read from an external PID file created by the wrapper script. The shutdown signals will now be handled by shutdown hook. Ticket #90 -- Endi S. Dewata
Was able to apply the patch and run a CA with the setting present: pidDir=/var/run/pki/ca Then observed the "getPID" function working correctly in the debugger. Also observed the new shutdown function being called when shutting down the CA. One quick question about the "pkicreate" portion: I noticed that since all subsystems are now going to use the pidDir setting, there was a TPS special case setting of the pidDir related variable moved to a place where all subsystems will pick up the code. The question is, since originally this was supposed to be only for RA and TPS, why was there not evidence of the line being moved out of the RA section? Perhaps we were not actually supporting this previously. Anyway, if that one thing is normal, ACK ----- Original Message ----- From: "Endi Sukma Dewata" <edewata@redhat.com> To: pki-devel@redhat.com Sent: Friday, February 24, 2012 8:38:29 AM Subject: [Pki-devel] [PATCH] 21 Removed OS subsystem. The OS subsystem was previously used to get the PID and to handle shutdown signals using the OSUtil. It has been removed because the functionalities can be obtained without using native code. The PID will now be read from an external PID file created by the wrapper script. The shutdown signals will now be handled by shutdown hook. Ticket #90 -- Endi S. Dewata _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On 2/28/2012 4:58 PM, John Magne wrote:
Was able to apply the patch and run a CA with the setting present:
pidDir=/var/run/pki/ca
Then observed the "getPID" function working correctly in the debugger. Also observed the new shutdown function being called when shutting down the CA.
One quick question about the "pkicreate" portion:
I noticed that since all subsystems are now going to use the pidDir setting, there was a TPS special case setting of the pidDir related variable moved to a place where all subsystems will pick up the code.
The question is, since originally this was supposed to be only for RA and TPS, why was there not evidence of the line being moved out of the RA section?
Perhaps we were not actually supporting this previously.
The PKI_PIDDIR is actually used by RA and TPS in the registry_instance script, not in CS.cfg. We don't really need it CS.cfg, but I added it there for consistency and in case we need it in the future.
Anyway, if that one thing is normal,
ACK
Thanks. Pushed to master. -- Endi S. Dewata
participants (2)
-
Endi Sukma Dewata -
John Magne