TRAC Ticket #869 - f19 ipa-server-install fails at step 6/22 of cert sys install - systemctl start pki-tomcatd.target fails
9:25 p.m.
Please review the following patch which addresses:
* PKI TRAC Ticket #869 - f19 ipa-server-install fails at step 6/22 of
cert sys install - systemctl start pki-tomcatd.target fails
<https://fedorahosted.org/pki/ticket/869>
This patch has been tested on Dogtag 10.0 on Fedora 19 using packages
built from the DOGTAG_10_0_BRANCH.
12:22 p.m.
In general, the patch is fine. Note that in the 10.1+, we have modified
the code to pass an array of commands to the system call. Make sure to
do that on those branches.
ACK.
On Wed, 2014-03-12 at 19:25 -0700, Matthew Harmsen wrote:
Please review the following patch which addresses:
* PKI TRAC Ticket #869 - f19 ipa-server-install fails at step
6/22 of cert sys install - systemctl start pki-tomcatd.target
fails
This patch has been tested on Dogtag 10.0 on Fedora 19 using packages
built from the DOGTAG_10_0_BRANCH.
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
12:34 p.m.
Also, I think we should be trying to clean up pylint warnings as we go
through and not add any new ones. That means for instance, that the new
method you added should contain a docstring class.
In fact, I would suggest making some changes to fix most of the pylint
warnings in say the Systemd class. There aren't that many - and if
everyone does it, we can slowly improve the code as we go.
If you want to do this only in master, thats fine with me too.
Ade
On Thu, 2014-03-13 at 13:22 -0400, Ade Lee wrote:
In general, the patch is fine. Note that in the 10.1+, we have
modified
the code to pass an array of commands to the system call. Make sure to
do that on those branches.
ACK.
On Wed, 2014-03-12 at 19:25 -0700, Matthew Harmsen wrote:
> Please review the following patch which addresses:
> * PKI TRAC Ticket #869 - f19 ipa-server-install fails at step
> 6/22 of cert sys install - systemctl start pki-tomcatd.target
> fails
>
> This patch has been tested on Dogtag 10.0 on Fedora 19 using packages
> built from the DOGTAG_10_0_BRANCH.
>
>
> _______________________________________________
> Pki-devel mailing list
> Pki-devel(a)redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
3699
days inactive
3699
days old
2 comments
2 participants
participants (2)
-
Ade Lee -
Matthew Harmsen