[PATCH] 607 Fixed NPE in ROOT's index.jsp.
The ROOT's index.jsp has been modified to check each subsystem's servlet context for null before accessing the value. https://fedorahosted.org/pki/ticket/1407 -- Endi S. Dewata
This code looks good and appears to make sense. Therefore ACK. Just a question though, did you come up with a test case to actually try this to solve the issue? ----- Original Message ----- From: "Endi Sukma Dewata" <edewata@redhat.com> To: "pki-devel" <pki-devel@redhat.com> Sent: Thursday, June 4, 2015 5:23:19 PM Subject: [Pki-devel] [PATCH] 607 Fixed NPE in ROOT's index.jsp. The ROOT's index.jsp has been modified to check each subsystem's servlet context for null before accessing the value. https://fedorahosted.org/pki/ticket/1407 -- Endi S. Dewata _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On 6/5/2015 8:50 PM, John Magne wrote:
This code looks good and appears to make sense.
Therefore ACK.
Thanks. Pushed to master.
Just a question though, did you come up with a test case to actually try this to solve the issue?
I tested the changes on an instance where the problem already happens. I'm not sure what exactly caused it, but I'm suspecting the Tomcat's behavior has changed in the newer version. Regardless, the changes should make the code more robust. -- Endi S. Dewata
participants (2)
-
Endi Sukma Dewata -
John Magne