[PATCH] 229 - Fix enroll_cert() in cert.py to handle rejected/canceled requests
Fix enroll_cert in cert.py to account for rejected requests Ticket 1109 Please review. Thanks, Ade
On 8/15/2014 4:19 PM, Ade Lee wrote:
Fix enroll_cert in cert.py to account for rejected requests
Ticket 1109
Please review.
Thanks, Ade
ACK. A possible improvement, we can also return objects with named attributes instead of tuples: results = cert_client.enroll_cert('caUserCert', inputs) for result in results: request = result.request cert = result.cert ... That way we can add more attributes into the result if necessary without changing the client code. -- Endi S. Dewata
On 8/15/2014 4:34 PM, Endi Sukma Dewata wrote:
On 8/15/2014 4:19 PM, Ade Lee wrote:
Fix enroll_cert in cert.py to account for rejected requests Ticket 1109 Please review.
Thanks, Ade
ACK.
Sorry, this line: if status == CertRequestStatus.COMPLETE: probably should have been: if status == CertRequestStatus.PENDING: -- Endi S. Dewata
Amended as suggested (and fixed as below). Pushed to master. Ade On Fri, 2014-08-15 at 16:37 -0500, Endi Sukma Dewata wrote:
On 8/15/2014 4:34 PM, Endi Sukma Dewata wrote:
On 8/15/2014 4:19 PM, Ade Lee wrote:
Fix enroll_cert in cert.py to account for rejected requests Ticket 1109 Please review.
Thanks, Ade
ACK.
Sorry, this line:
if status == CertRequestStatus.COMPLETE:
probably should have been:
if status == CertRequestStatus.PENDING:
participants (2)
-
Ade Lee -
Endi Sukma Dewata