On 8/21/2012 2:02 PM, Endi Sukma Dewata wrote:

On 8/20/2012 12:50 PM, Endi Sukma Dewata wrote:

...

The pki-common package has been split such that the common and client binaries are packaged in pki-base and server binaries are packaged in pki-server. The pki-util has been merged into pki-base and the pki-deploy package has been merged into pki-server.

Ticket #295

New patch attached. The old package definition wasn't removed properly.

New patch attached. Updated pki-console.spec, dogtag-pki.spec, and some other files. -- Endi S. Dewata

On 8/27/2012 10:26 PM, Ade Lee wrote:

1. As discussed on #irc, please add a patch to handle the javadoc packages.

I opened a ticket for this: https://fedorahosted.org/pki/ticket/305

2. How did you determine the Requires for pki-base? We do not want to install more than is necessary on a client. For example, it isn't clear to me that jython should be a requirement for pki-base. Rather it should have been a requirement for pki-deploy - which becomes part of pki-server.

The original pki-common's Requires were split for pki-base (combined with pki-util) and pki-server. Ideally all server-specific Requires should go to pki-server. But it's difficult to make a clean split without inspecting the code and running tests. So this patch contains a pretty safe split, the pki-base may contain more than required, but it wouldn't hurt and can be refined again.

Similarly the following seem to be requirements for pki-server rather than pki-base: pki-common-theme, velocity, tomcatjss, pki-symkey, (jss?)

OK, I'll move the Requires as follows: * pki-common-theme, velocity, & tomcatjss ==> pki-server * pki-symkey ==> pki-tks Should we rename pki-common-theme to pki-server-theme? The jss will stay in pki-base because it's required by the clients.

3. The following should probably be replaced by packages (if possible): Requires: %{_javadir}/velocity.jar Requires: %{_javadir}/xalan-j2.jar Requires: %{_javadir}/xalan-j2-serializer.jar Requires: %{_javadir}/xerces-j2.jar Requires: %{_javadir}/xml-commons-apis.jar Requires: %{_javadir}/xml-commons-resolver.jar

This is an existing issue, it should be addressed separately: https://fedorahosted.org/pki/ticket/306

And then we should ask whether they are requirements for pki-base or pki-server.

I'll move the velocity.jar to pki-server, but the rest might have to wait. Those XML libraries could be needed indirectly by pki-base.

4. pki-symkey: I know we said this will likely eventually be folded into jss. But this is only used by the tks. So it should be a requirement for either pki-server or pki-tks.

Yes, this goes to pki-tks and we'll remove it once it's merged into jss.

5. Its also an interesting question as to whether velocity is in fact a requirement for the *-theme packages, rather than pki-server.

To my understanding the themes only contain velocity scripts and we only need the velocity.jar when the server runs it. I'll post a revised patch with these changes. -- Endi S. Dewata

On 8/29/2012 5:04 PM, Endi Sukma Dewata wrote:

On 8/28/2012 3:02 PM, Endi Sukma Dewata wrote:

...

I'll post a revised patch with these changes.

New patch attached.

Fixed velocity dependency. ACKed by Ade. Pushed to master. -- Endi S. Dewata